Skip to content

remove internalHeader folder whose file is only used in unit test #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2019
Merged

remove internalHeader folder whose file is only used in unit test #3537

merged 1 commit into from
Aug 8, 2019

Conversation

@charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Aug 8, 2019

No description provided.

maksymmalyhin
maksymmalyhin approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlotteliang charlotteliang merged commit f090a3c into master Aug 8, 2019
@charlotteliang charlotteliang deleted the fcm-internal-header branch August 8, 2019 20:00
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@morganchen12 morganchen12 morganchen12 approved these changes

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@charlotteliang @paulb777 @maksymmalyhin @morganchen12 @googlebot